-
Notifications
You must be signed in to change notification settings - Fork 126
Update Installation Guide: Add ESP-IDF Support Policy, Optimize PlatformIO Configuration, and Fix Missing array.h Compilation Issue (TFMIC-47) #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@001ProMax thanks for the PR, let me try the steps and get back to you.
|
| lib_deps = | ||
| https://github.com/espressif/esp-tflite-micro.git | ||
|
|
||
| ; src_dir = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@001ProMax isn't src_dir a global option? Setting it under env just ignores it completely
You can instead create platformio.ini files for the examples, users can then directly run them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not using this approach right now. Just following the standard PlatformIO file structure.
|
Hey @001ProMax |
The |
|
When will this PR be merged? Or, is there another way to automatically generate array.h in PlatformIO? |
| @@ -0,0 +1,123 @@ | |||
| /* Copyright 2023 The TensorFlow Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @001ProMax is this file really needed here? Please remove it if not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is required for PlatformIO to work correctly, so it shouldn’t be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@001ProMax
Since our build is static, and rightly so, tensorflow/lite/micro/tools/project_generation/create_tflm_tree.py script does not copy these files by itself.
- I would suggest you to please check if this file include can be avoided.
- If it is absolutely needed, I suggest you to modify the script esp-tflite-micro/scripts/sync_from_tflite_micro.sh
- Copy this header from the tflite-micro clone right after it runs
create_tflm_tree.py. This will make sure, it is copied with each sync. Do add a comment above the file copy that this is done so for a specific reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another problem I have with the file is it may conflict with the standard C++ header. But it may be okay, since we do not directly include this directory as direct path to compiler (Using -I)
This PR optimizes the installation guide and fixes a critical issue for PlatformIO users. The changes include:
Provided a clear and concise configuration example for PlatformIO users, including necessary build_flags and lib_deps.
Resolved the issue where array.h was missing during PlatformIO compilation by ensuring the correct include paths and dependencies are specified.